Ticket #898 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

Various monitor mode fixes

Reported by: scottraynel@gmail.com Assigned to:
Priority: major Milestone: version 0.9.3
Component: madwifi: other Version: trunk
Keywords: Cc:
Patch is attached: 1 Pending:

Description

The attached patch fixes several issues with monitor mode:

  • Record the correct rate for transmitted packets (both prism and radiotap encapsulations were referencing the rx rate even for tx frames, which was wrong).
  • Record the antenna for tranmitted packets instead of just using 0
  • Record the TSF for tranmitted packets when using radiotap
  • Don't expose kernel memory to userspace in ieee80211_input_monitor

ieee80211_input_monitor was taking a u_int32_t containing the TSF for the frame, but was copying 8 bytes of memory into the monitoring header from it's address. This patch changes ieee80211_input_monitor to take a u_int64_t and touches the appropriate parts in ath/if_ath.c.

Attachments

madwifi_monitor_tx_rate_antenna_tsf.patch (5.7 kB) - added by scottraynel@gmail.com on 09/20/06 04:51:41.
Signed-off-by: Scott Raynel <scottraynel@gmail.com>

Change History

09/20/06 04:51:41 changed by scottraynel@gmail.com

  • attachment madwifi_monitor_tx_rate_antenna_tsf.patch added.

Signed-off-by: Scott Raynel <scottraynel@gmail.com>

09/20/06 04:54:41 changed by scottraynel@gmail.com

If this gets applied it will also close #568

09/20/06 06:43:43 changed by mrenzmann

  • milestone set to version 0.9.3.

Thanks for the work, Scott. The patch looks good, should be committed. Volunteers? :)

09/20/06 06:58:46 changed by kelmo

  • status changed from new to closed.
  • resolution set to fixed.

Applied in r1720

Add/Change #898 (Various monitor mode fixes)