Ticket #876 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

[patch] Prism header - frame length

Reported by: oliver.stampfli@epfl.ch Assigned to:
Priority: trivial Milestone: version 0.9.3
Component: madwifi: driver Version: trunk
Keywords: Cc:
Patch is attached: 1 Pending:

Description (Last modified by mrenzmann)

In monitor mode the frame length that the driver gets from the skbuff variable is already the length of the MAC frame and does not need a correction (minus sizeof(prismheader)).

After the patch the lenght of a MAC frame is reproted correctly in ethereal etc. in bigendian like the other fields in the prismheader.

I found this bug because when you have a 802.11 ACK which has always 14 Bytes ethereal reproted a weird frame length. The problem is that the prismheader has a size of 144Bytes so when you do the math 14-144 for an uint32 you will get a very large 802.11 ACK Packet.

svn info: 

Repository UUID: 0192ed92-7a03-0410-a25b-9323aeb14dbd
Revision: 1705
Node Kind: directory
Schedule: normal
Last Changed Author: proski
Last Changed Rev: 1705
Last Changed Date: 2006-08-15 19:14:37 +0200 (Tue, 15 Aug 2006)
Properties Last Updated: 2006-08-25 13:33:08 +0200 (Fri, 25 Aug 2006)

Signed-off-by: Oliver Stampfli <oliver.stampfli@epfl.ch>

Attachments

patch-prism-frm-len.diff (0.6 kB) - added by oliver.stampfli@epfl.ch on 09/12/06 13:50:04.

Change History

09/12/06 13:50:04 changed by oliver.stampfli@epfl.ch

  • attachment patch-prism-frm-len.diff added.

09/12/06 14:59:20 changed by mrenzmann

  • description changed.
  • milestone set to version 0.9.3.

Patch looks good, no objections from my side. Anyone up for committing it to the repos?

09/13/06 04:46:53 changed by mentor

  • status changed from new to closed.
  • resolution set to fixed.

r1709

Add/Change #876 ([patch] Prism header - frame length)