Ticket #694 (closed enhancement: fixed)

Opened 6 years ago

Last modified 6 years ago

Please permit build of trees from "svn export"

Reported by: lool+madwifi@via.ecp.fr Assigned to: kelmo
Priority: major Milestone: version 0.9.1
Component: madwifi: other Version: trunk
Keywords: Cc:
Patch is attached: 1 Pending:

Description

Hi,

Would be nice if you could permit building of madwifi with trees/tarballs generated from 

svn export

(that is without the .svn/ dirs carrying revision information)

This currently fails because svnversion.h is missing.

Thanks,

Attachments

allow-compile-from-pristine-tarball.patch (1.7 kB) - added by kelmo on 06/16/06 13:15:42.
allow exported archive to compile

Change History

06/14/06 15:51:33 changed by kelmo

  • status changed from new to assigned.
  • owner set to kelmo.

This should not happen, will accept ownership of this problem and investigate possible solutions to eliminate this behaviour.

Kel.

06/16/06 13:15:42 changed by kelmo

  • attachment allow-compile-from-pristine-tarball.patch added.

allow exported archive to compile

06/16/06 13:18:09 changed by kelmo

  • patch_attached set to 1.

Hi, I've attached a patch to correct this trivial compilation failure, by adjusting the release mechanism to always fallback to a hardcoded release number when svnversion.h is not created (pristine tarball or svn export). This version number is changes by make-release.bash on every release.

lool, does this fix the problem?

Can anyone see possible problems?

06/16/06 15:03:18 changed by anonymous

Yes, it fixes the problem.

06/18/06 23:12:45 changed by kelmo

  • status changed from assigned to closed.
  • resolution set to fixed.

Was committed to r1647.

06/19/06 09:40:35 changed by mrenzmann

  • version set to trunk.
  • milestone set to version 0.9.1.

Add/Change #694 (Please permit build of trees from "svn export")