Ticket #667 (closed defect: fixed)

Opened 6 years ago

Last modified 6 years ago

Changeset 1627 - CONFIG_CRYPTO errors in Makefile

Reported by: anonymous Assigned to: mentor
Priority: minor Milestone: version 0.9.1
Component: madwifi: makefiles Version:
Keywords: Cc:
Patch is attached: 0 Pending:

Description (Last modified by mentor)

There is an error in changeset 1627 Makefile line 183 says: 

@if [ -z "$(CONFIG_CRYPTO_AES)" ] || [ -z "$(CONFIG_CRYPTO_AES_586)" ]; then \

And this should be: 

@if [ -z "$(CONFIG_CRYPTO_AES)" ] && [ -z "$(CONFIG_CRYPTO_AES_586)" ]; then \

Regards, Philip

Attachments

Change History

06/05/06 21:42:55 changed by dyqith

  • status changed from new to closed.
  • resolution set to fixed.

I got bitten by this too.

Fixed in the latest svn release.

Sorry.

06/05/06 22:34:25 changed by anonymous

Wow, that was fast. Thank you.

Regards, Philip

06/06/06 08:10:56 changed by puferd@seznam.cz

  • status changed from closed to reopened.
  • resolution deleted.

Hi, you probably forgot about 64 bit platforms regarding arch specific AES crypto module. What about CONFIG_CRYPTO_AES_X86_64 when compiling for AMD64 or EM64T?

06/06/06 12:54:56 changed by kelmo

There were no comments to the discussion in #579 (which resulted in r1624).

CONFIG_AES, should it be an absolute dependency for compiling MadWifi?

Is an arch specific check really neccessary in any case? (CONFIG_AES is always present, iirc).

My 2c worth.

06/06/06 15:57:34 changed by dyqith

  • summary changed from Changeset 1627 to Changeset 1627 - CONFIG_CRYPTO errors in Makefile.

Kel, That's a good point. Maybe, some of the crypto modules can be not-compiled when the flags are not set?

as for CONFIG_CRYPTO_AES_X86_64, i have no way to test this since I don't have a 64bit machine. Maybe someone else can take a look ?

06/06/06 20:45:22 changed by mentor

  • status changed from reopened to new.
  • owner set to mentor.

Sorry, this was my commit. It should be 

@if [ -z "$(CONFIG_CRYPTO_AES)" ] || [ -z "$(CONFIG_CRYPTO_AES_586)" ]; then \

Which is what I commited from my local copy. The CCMP crypto module needs the kernel AES support to initialise properly, even if there is hardware support. As the module is always compiled and we alwayss depend on CRYPTO support, I thought this was a reasonable hard dependency.

I'm working on fixing this stuff properly, but I'm confused by the key setup process, which appears to be inconsistent (notably, hostapd has a comment about this).

I'm going to try and recommit properly.

06/06/06 20:46:22 changed by mentor

  • status changed from new to assigned.
  • description changed.

Oh. I see.

06/06/06 21:26:24 changed by mentor

  • status changed from assigned to closed.
  • resolution set to fixed.

Fixed in 1629. Do I get points for the four dollars in a row? 

@if [ -z "$(shell for var in $${!CONFIG_CRYPTO_AES*}; do eval echo \$$$$var; done)" ]; then \

06/06/06 23:13:39 changed by kelmo

No => #670 ;-)

06/06/06 23:16:54 changed by kelmo

Why is it neccessary to look for the arch specific module? 

$ zgrep CRYPTO_AES /proc/config.gz
CONFIG_CRYPTO_AES=m
CONFIG_CRYPTO_AES_586=y

$ zgrep CRYPTO_AES /proc/config.gz
CONFIG_CRYPTO_AES=m
CONFIG_CRYPTO_AES_X86_64=m

06/06/06 23:21:42 changed by kelmo

As far as I understand, CONFIG_CRYPTO_AES provides the module, CONFIG_CRYPTO_AES_$ARCH provides architecture specific optimisations.

06/07/06 02:52:42 changed by mentor

crypto/Kconfig: 

config CRYPTO_AES
        tristate "AES cipher algorithms"
        depends on CRYPTO && !(X86 || UML_X86)

config CRYPTO_AES_586
        tristate "AES cipher algorithms (i586)"
        depends on CRYPTO && ((X86 || UML_X86) && !64BIT)

Which seems to indicate that CONFIG_CRYPTO_AES isn't enabled when an arch specific module is enabled. Which is what also appears to happen in menuconfig. It's just not what happens in the .config. Fixing with the observed behaviour. Sorry. Really.

Ummm, also, when testing shell things, clear your environment first, mmm'kay.

06/19/06 09:23:30 changed by mrenzmann

  • milestone set to version 0.9.1.

Add/Change #667 (Changeset 1627 - CONFIG_CRYPTO errors in Makefile)