Ticket #2284 (new defect)

Opened 3 years ago

Last modified 3 years ago

madwifi-0.9.4.x branch on gcc44/2.6.29.1: the frame size of 1288 bytes is larger than 1024 bytes

Reported by: Axel.Thimm@ATrpms.net Assigned to:
Priority: minor Milestone:
Component: madwifi: 802.11 stack Version: v0.9.4
Keywords: Cc:
Patch is attached: 0 Pending: 0

Description

On Fedora rawhide I get with the 0.9.4 branch the following error: 

  CC [M]  /builddir/madwifi-0.9.4.1/net80211/ieee80211_scan.o
  CC [M]  /builddir/madwifi-0.9.4.1/net80211/ieee80211_wireless.o
cc1: warnings being treated as errors
/builddir/madwifi-0.9.4.1/net80211/ieee80211_wireless.c: In function 'ieee80211_ioctl_iwaplist':
/builddir/madwifi-0.9.4.1/net80211/ieee80211_wireless.c:1468: error: the frame size of 1288 bytes is larger than 1024 bytes
make[3]: *** [/builddir/madwifi-0.9.4.1/net80211/ieee80211_wireless.o] Error 1
make[2]: *** [/builddir/madwifi-0.9.4.1/net80211] Error 2
make[1]: *** [_module_/builddir/madwifi-0.9.4.1] Error 2
make[1]: Leaving directory `/srv/atrpms.net/atrpms/kernelsrc/f11-i386/2.6.29.1-70.fc11-i586'
make: *** [modules] Error 2

Maybe I picked the wrong branch? I already packaged madwifi-free from trunk, but I wanted to also offer a legacy version in case the madwifi-free one has some regression.

Thanks!

Attachments

madwifi-r4020-gcc4.4.diff (3.3 kB) - added by Andras Korn on 05/09/09 15:29:00.
gcc4.4 patch for r4020

Change History

(in reply to: ↑ description ) 04/20/09 09:29:59 changed by Axel.Thimm@ATrpms.net

Replying to Axel.Thimm@ATrpms.net:

On Fedora rawhide I get with the 0.9.4 branch the following error: 

/builddir/madwifi-0.9.4.1/net80211/ieee80211_wireless.c:1468: error: the frame size of 1288 bytes is larger than 1024 bytes

... I already packaged madwifi-free from trunk, ...

Actually I hadn't packaged it for F11, the error is in trunk as well. Unfortunately I cannot change any of the bugs properties to reflect that.

(in reply to: ↑ description ) 04/26/09 18:51:56 changed by Marcin Łabanowski

I've faced the same errors. The issue is, that gcc 4.4 allows maximum 1024 bytes of stack for function. I've replaced some static arrays and structs to kmalloc'd pointers. Note that this is my first kernel patch, although I can confirm it works well for me.

http ://rydzyk.net/madwifi-gcc4.4.patch

05/06/09 20:14:44 changed by pavel.murat@gmail.com

thanks! this worked for me, I used kmalloc with GFP_USER though to patch.

I confirm that ath_pci is working with kernel 2.6.29.2-126.fc11.i686.PAE significantly more reliable than ath5k which I blacklisted.

The problem with ath5k I was experiencing on Fujitsu S7110 with an _old_ Atheros AR242x chip was rather obscure: approximately once in every 1-2min the network access was getting stuck unidirectionally for about 10-15sec: ath5k was sending bytes out but not receiving the input from the network properly. After switching to madwifi's ath_pci I no longer see this problem reappearing.

05/09/09 15:29:00 changed by Andras Korn

  • attachment madwifi-r4020-gcc4.4.diff added.

gcc4.4 patch for r4020

05/09/09 15:30:22 changed by Andras Korn

I updated Marcin's patch marginally to compile r4020. It appears to work, but it's not pretty.

Add/Change #2284 (madwifi-0.9.4.x branch on gcc44/2.6.29.1: the frame size of 1288 bytes is larger than 1024 bytes)