Please note: This project is no longer active. The website is kept online for historic purposes only.
If you´re looking for a Linux driver for your Atheros WLAN device, you should continue here .

Ticket #2110 (new defect)

Opened 13 years ago

Incorrect use of sc->sc_dfs_cac_timer.data

Reported by: proski Assigned to: proski
Priority: major Milestone:
Component: madwifi: driver Version: trunk
Keywords: DFS Cc:
Patch is attached: 0 Pending: 0

Description

It appears that some DFS code is never executed because a comparison is always wrong.

Both in the trunk and the DFS branch, sc->sc_dfs_cac_timer.data is set to sc in ath_attach(), but ath_newstate() compares it to vap. Those variables are pointers to struct ath_softc and struct ieee80211vap respectively. They cannot legitimately point to the same address in memory, thus the condition is always false.

The 0.9.4 branch has that code as well, except that the variable is called sc->sc_dfswaittimer.data

The code is very old. It was present in the original import of madwifi-ng (revision 1175).