Ticket #2014 (closed defect: invalid)

Opened 4 years ago

Last modified 3 years ago

ath5k does not trim crc32 at the tail of frame

Reported by: bitbucket@yandex.ru Assigned to:
Priority: critical Milestone:
Component: ath5k Version: trunk
Keywords: ath5k crc32 trim Cc:
Patch is attached: 1 Pending: 0

Description

crc32 at the end of a 802.11 frame, received from hw is not cuted up. In madwifi/ath_pci.c it is done.

Proposed patch: 

--- base.c.old  2008-06-18 08:10:59.000000000 +0400
+++ base.c      2008-06-25 14:33:33.000000000 +0400
@@ -1862,6 +1862,8 @@
                        skb_pull(skb, pad);
                }

+               skb_trim(skb, skb->len - 4); // IEEE80211_CRC_LEN
+
                /*
                 * always extend the mac timestamp, since this information is
                 * also needed for proper IBSS merging.

Attachments

Change History

06/25/08 16:51:55 changed by anonymous

that's the FCS! No need to do anything here... it's alright the way it is. <close>

11/21/08 14:24:27 changed by mrenzmann

  • status changed from new to closed.
  • resolution set to invalid.
  • pending changed.

Both, ath5k and ath9k, are part of the kernel some time now. It's better for everyone to have bug reports for those drivers in the kernel bugzilla, as they will likely get better attention there. Hence from now on we don't accept new tickets for ath5k/ath9k here.

We talked to Linux Wireless developers about how to best handle tickets that already have been filed here for ath5k/ath9k. The original idea was to copy those bugs over to the kernel bugzilla. But then many of these tickets have not seen any activity for a while, and it's not clear if the reported issue still exists or if the reporter is even still around to answer bugs.

In the end we agreed that it would be best to ask people to open a new ticket at bugzilla.kernel.org for those issues that still exist in the latest version of ath5k/ath9k, and close related tickets here. This is what I do now (closing as invalid, since that seems to be the best matching resolution available).

Sorry for the inconvenience, and thank you for your understanding.

Add/Change #2014 (ath5k does not trim crc32 at the tail of frame)