Ticket #1895 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

r3556 recent changes to if_ath.c breaks compile on amd64 machine

Reported by: tyler.merrill@gmail.com Assigned to: benoit
Priority: minor Milestone: version 0.9.5
Component: madwifi: other Version: trunk
Keywords: Cc:
Patch is attached: 0 Pending:

Description

First ticket submission so forgive me if I don´t include everything I need to. Yesterday I downloaded from SVN and compiled fine. Today with the recent r3556 changes, it will not compile. Output is as follows. 

Checking requirements... ok.
Checking kernel configuration... ok.
make -C /lib/modules/2.6.22-14-generic/build SUBDIRS=/tmp/src/madwifi modules
make[1]: Entering directory `/usr/src/linux-headers-2.6.22-14-generic'
  CC [M]  /tmp/src/madwifi/ath/if_ath.o
cc1: warnings being treated as errors
/tmp/src/madwifi/ath/if_ath.c: In function 'ath_txq_dump':
/tmp/src/madwifi/ath/if_ath.c:2871: warning: format '%08x' expects type 'unsigned int', but argument 5 has type 'dma_addr_t'
make[3]: *** [/tmp/src/madwifi/ath/if_ath.o] Error 1
make[2]: *** [/tmp/src/madwifi/ath] Error 2
make[1]: *** [_module_/tmp/src/madwifi] Error 2
make[1]: Leaving directory `/usr/src/linux-headers-2.6.22-14-generic'
make: *** [modules] Error 2

Attempting to build on an AMD64 install of Ubuntu 7.10.

Change History

04/21/08 09:36:57 changed by mrenzmann

  • owner set to benoit.

(follow-up: ↓ 3 ) 04/21/08 09:37:43 changed by mrenzmann

I've checked with the reporter that the reported issue has been introduced in r3552. Benoit, please fix :)

(in reply to: ↑ 2 ) 04/21/08 17:35:45 changed by rggjan@gmail.com

Replying to mrenzmann:

I've checked with the reporter that the reported issue has been introduced in r3552. Benoit, please fix :)

Yes, same problem here. A fix would be nice ;-)

04/21/08 22:13:37 changed by benoit

I could make a simple cast to u_int32_t since the hardware expects a 32 bits value. However, I'd prefer to investigate a bit with dma_addr_t and why it's 64 bits here.

04/21/08 23:25:08 changed by benoit

  • status changed from new to closed.
  • resolution set to fixed.

04/21/08 23:25:33 changed by benoit

Fixed by r3559

04/22/08 05:59:32 changed by mrenzmann

  • milestone set to version 0.9.5.