Please note: This project is no longer active. The website is kept online for historic purposes only.
If you´re looking for a Linux driver for your Atheros WLAN device, you should continue here .

Ticket #1318 (new defect)

Opened 15 years ago

Last modified 15 years ago

diversity should not be dependent upon XR

Reported by: tharvey Assigned to:
Priority: minor Milestone:
Component: madwifi: other Version: v0.9.3
Keywords: diversity Cc:
Patch is attached: 1 Pending:

Description

The code in ath_if.c will not allow you to set diversity if XR is enabled (according to the comment) however its not checking the state of XR correctly. Instead of seeing if XR is enabled on any VAP (as its a per vap stat) it checks to see if the card is 'XR capable' which is not the right thing to do. Additionally if a chipset supports diversity it will be enabled by default without any dependence on XR which is inconsistent.

I don't see any reason to have this dependence on XR. With the current code if you have an XR capable card diversity will be defaulted on. You can turn it off, but you will never be able to turn it on again.

The patch attached will remove the dependence upon XR

Attachments

diversity_wo_xr.patch (0.9 kB) - added by tharvey on 05/16/07 15:13:32.
Patch to disable dependence upon XR when setting diversity

Change History

05/16/07 15:13:32 changed by tharvey

  • attachment diversity_wo_xr.patch added.

Patch to disable dependence upon XR when setting diversity

05/18/07 06:15:30 changed by mrenzmann

Please sign off your patch. Thanks.

08/07/07 23:46:14 changed by redbyte

Would be nice to sign off the patch so it can go into the current code.