Ticket #131 (closed defect: fixed)

Opened 6 years ago

Last modified 6 years ago

Compilation failure when AR_DEBUG or IEEE80211_DEBUG are undefined

Reported by: David Pufer Assigned to:
Priority: minor Milestone: version 0.9.1
Component: madwifi: driver Version: trunk
Keywords: debug define compilation error Cc:
Patch is attached: 1 Pending:

Description (Last modified by mrenzmann)

I get compilation failure when undef AR_DEBUG in if_ath.c, line 75 (revision 1302). It looks like this:

make[2]: Entering directory `/usr/src/linux-2.6.13-suspend2-r4'
  CC [M]  /home/madwifi/a/madwifi-ng/ath/if_ath.o
/home/madwifi/a/madwifi-ng/ath/if_ath.c: In function `ath_attach':
/home/madwifi/a/madwifi-ng/ath/if_ath.c:389: error: `ath_debug' undeclared (first use in this function)
/home/madwifi/a/madwifi-ng/ath/if_ath.c:389: error: (Each undeclared identifier is reported only once
/home/madwifi/a/madwifi-ng/ath/if_ath.c:389: error: for each function it appears in.)
/home/madwifi/a/madwifi-ng/ath/if_ath.c: In function `ath_suspend':
/home/madwifi/a/madwifi-ng/ath/if_ath.c:1220: warning: unused variable `sc'
/home/madwifi/a/madwifi-ng/ath/if_ath.c: In function `ath_resume':
/home/madwifi/a/madwifi-ng/ath/if_ath.c:1229: warning: unused variable `sc'
/home/madwifi/a/madwifi-ng/ath/if_ath.c: In function `ath_shutdown':
/home/madwifi/a/madwifi-ng/ath/if_ath.c:1238: warning: unused variable `sc'
/home/madwifi/a/madwifi-ng/ath/if_ath.c: In function `ath_rx_tasklet':
/home/madwifi/a/madwifi-ng/ath/if_ath.c:5373: warning: implicit declaration of function `netif_msg_dumppkts'
/home/madwifi/a/madwifi-ng/ath/if_ath.c: In function `ath_tx_draintxq':
/home/madwifi/a/madwifi-ng/ath/if_ath.c:7143: warning: unused variable `ah'
/home/madwifi/a/madwifi-ng/ath/if_ath.c: In function `ath_dynamic_sysctl_register':
/home/madwifi/a/madwifi-ng/ath/if_ath.c:9192: error: `ath_debug' undeclared (first use in this function)
make[3]: *** [/home/madwifi/a/madwifi-ng/ath/if_ath.o] Error 1
make[2]: *** [_module_/home/madwifi/a/madwifi-ng/ath] Error 2
make[2]: Leaving directory `/usr/src/linux-2.6.13-suspend2-r4'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/home/madwifi/a/madwifi-ng/ath'
make: *** [all] Error 1

When I undef IEEE80211_DEBUG in ieee80211_var.h line 40, I get the following:

  LD [M]  /home/madwifi/madwifi-ng/ath_hal/ath_hal.ko
make[2]: Leaving directory `/usr/src/linux-2.6.13-suspend2-r4'
make[1]: Leaving directory `/home/madwifi/madwifi-ng/ath_hal'
make[1]: Entering directory `/home/madwifi/madwifi-ng/net80211'
make -C /usr/src/linux-2.6.13-suspend2-r4 SUBDIRS=/home/madwifi/madwifi-ng/net80211 MODVERDIR=/home/madwifi/madwifi-ng/net80211/../symbols modules
make[2]: Entering directory `/usr/src/linux-2.6.13-suspend2-r4'
  CC [M]  /home/madwifi/madwifi-ng/net80211/if_media.o
  CC [M]  /home/madwifi/madwifi-ng/net80211/ieee80211.o
  CC [M]  /home/madwifi/madwifi-ng/net80211/ieee80211_beacon.o
/home/madwifi/madwifi-ng/net80211/ieee80211_beacon.c: In function `ieee80211_beacon_alloc':
/home/madwifi/madwifi-ng/net80211/ieee80211_beacon.c:225: warning: implicit declaration of function `IEEE80211_NOTE'
make[3]: *** [/home/madwifi/madwifi-ng/net80211/ieee80211_beacon.o] Error 1
make[2]: *** [_module_/home/madwifi/madwifi-ng/net80211] Error 2
make[2]: Leaving directory `/usr/src/linux-2.6.13-suspend2-r4'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/home/madwifi/madwifi-ng/net80211'
make: *** [all] Error 1

When compiling vanilla source, everything works as expected. This problem is probably related to changeset 372 in the trunk.

Attachments

madwifi-debug.diff (1.6 kB) - added by mentor on 05/20/06 18:24:13.
Patch
madwifi-debug.2.diff (1.6 kB) - added by mentor on 05/20/06 18:25:22.
Patch - No Typos - hopefully

Change History

11/07/05 07:42:56 changed by mrenzmann

  • description changed.

11/07/05 14:57:19 changed by mrenzmann

  • milestone changed from version 0.9.0 - move to new codebase to version 1.0.0 - first stable release.

05/20/06 18:23:33 changed by mentor

  • patch_attached changed.

Signed-Off-By: Matthew W. S. Bell <m.bell@bvrh.co.uk>

Make sure everything is defined in the cases of the *_DEBUG macros being defined and undefined.

05/20/06 18:24:13 changed by mentor

  • attachment madwifi-debug.diff added.

Patch

05/20/06 18:25:22 changed by mentor

  • attachment madwifi-debug.2.diff added.

Patch - No Typos - hopefully

05/20/06 18:26:06 changed by mentor

  • patch_attached set to 1.

05/31/06 22:59:58 changed by mentor

  • status changed from new to closed.
  • resolution set to fixed.

Patch commited in r1613. Marking closed.

06/19/06 09:16:09 changed by mrenzmann

  • milestone changed from version 1.0.0 - first stable release to version 0.9.1.

Add/Change #131 (Compilation failure when AR_DEBUG or IEEE80211_DEBUG are undefined)