Ticket #1300 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

trunk - ah_os.h brocken by [2307]

Reported by: Andreas Schultz <aschultz@warp10.net> Assigned to: mentor
Priority: blocker Milestone:
Component: madwifi: other Version: trunk
Keywords: Cc:
Patch is attached: 0 Pending:

Description

_OS_REG_WRITE is brocken in changeset[2307]. Did anybody try to actually compile that???

_OS_REG_WRITE is missing a \ in the second to last line, should be: 

#define _OS_REG_WRITE(_ah, _reg, _val) do {                     \
        (0x4000 <= (_reg) && (_reg) < 0x5000) ?                 \
         writel((_val), (_ah)->ah_sh + (_reg)) :                \
         ({__raw_writel((_val), (_ah)->ah_sh + (_reg));         \
           mb(); });                                            \
} while (0)

adding that, the compiler still complains: /usr/src/gateway/tplino-trunk-bcm68/build_mips/linux-2.6-brcm63xx/madwifi-hal-0.9.30.13/ath_hal/ah_os.c:335: error: parse error before "do" /usr/src/gateway/tplino-trunk-bcm68/build_mips/linux-2.6-brcm63xx/madwifi-hal-0.9.30.13/ath_hal/ah_os.c:335: error: parse error before ':' token

on a side note: are you sure the mb() in those places is syntactical correct?

Attachments

Change History

05/08/07 13:57:17 changed by strasak@bubakov.net

compiled here OK but on LE architectures only, and that is i guess the problem, that most of early testers and adopters use LE only :)
Ignus

05/08/07 13:58:00 changed by mrenzmann

  • owner set to mentor.

05/08/07 14:00:20 changed by mrenzmann

I can confirm that r2316 compiles without any issues on x86. Quickly tested on a Debian Sarge box with GCC 3.3.5-13 against kernel 2.6.20.1.

Matthew, could you please investigate?

05/09/07 06:01:06 changed by mentor

  • status changed from new to closed.
  • resolution set to fixed.

r2318. Sorry.

Add/Change #1300 (trunk - ah_os.h brocken by [2307])