Ticket #1096 (closed enhancement: fixed)

Opened 5 years ago

Last modified 5 years ago

simplify ieee80211_node->ni_rxfrag

Reported by: Mark Glines <mark@glines.org> Assigned to: mentor
Priority: trivial Milestone: version 0.9.3
Component: madwifi: 802.11 stack Version: trunk
Keywords: Cc:
Patch is attached: 1 Pending:

Description

Hi,

While debugging a crash, I noticed the ni_rxfrag data structure is more complex than it needs to be. It is an array of 4 skbs, but only the first member of this array is used. ieee80211_input() defragments incoming fragmented packets by concatenating them onto the end of ni_rxfrag[0]. So... why is it an array to begin with? It took me a while to figure this code out, because of the unnecessary complexity.

I'll attach a patch to simplify it.

Attachments

simplify_ni_rxfrag.diff (7.0 kB) - added by Mark Glines <mark@glines.org> on 01/17/07 17:37:41.
diff against svn trunk
simplify_ni_rxfrag_2.diff (7.0 kB) - added by Mark Glines <mark@glines.org> on 02/01/07 20:40:12.
Same diff, refreshed to svn r2059. Signed-off-by: Mark Glines <mark@glines.org>

Change History

01/17/07 17:37:41 changed by Mark Glines <mark@glines.org>

  • attachment simplify_ni_rxfrag.diff added.

diff against svn trunk

02/01/07 15:24:36 changed by mentor

  • status changed from new to assigned.
  • owner set to mentor.

02/01/07 15:26:10 changed by mentor

[DevDocs/SigningPatches]

02/01/07 20:40:12 changed by Mark Glines <mark@glines.org>

  • attachment simplify_ni_rxfrag_2.diff added.

Same diff, refreshed to svn r2059. Signed-off-by: Mark Glines <mark@glines.org>

02/02/07 05:46:32 changed by mentor

  • status changed from assigned to closed.
  • resolution set to fixed.

02/02/07 06:28:26 changed by mrenzmann

  • milestone set to version 0.9.3.

Patch committed in r2068.

Add/Change #1096 (simplify ieee80211_node->ni_rxfrag)