Ticket #1039 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

FastFrames statistics are not incremented correctly

Reported by: Žilvinas Valinskas <zilvinas@wilibox.com> Assigned to:
Priority: trivial Milestone: version 0.9.3
Component: madwifi: driver Version: trunk
Keywords: Cc:
Patch is attached: 1 Pending:

Description

In case FastFrames? (FF) are enabled, 80211stats reports incorrect 'tx_data' and 'tx_bytes' counters. Statistics are incremented only once, for a first chained skb only. So if FF enabled one should increment statistics accordingly for a second (if any) chained skb too.

Without this fix, during duplex tests it is clearly seen that 'rx_data' and 'rx_bytes' are about 2x larger then 'tx_data/tx_bytes' counters when these counters should be about the same.

Attachments

0001-trivial-FF-accounting-fix.txt (1.3 kB) - added by Žilvinas Valinskas on 12/11/06 16:52:29.
trivial patch

Change History

12/11/06 16:52:29 changed by Žilvinas Valinskas

  • attachment 0001-trivial-FF-accounting-fix.txt added.

trivial patch

12/14/06 22:11:40 changed by scottr

  • status changed from new to closed.
  • resolution set to fixed.
  • milestone set to version 0.9.3.

Thanks for the patch, committed in r1860. Cheers.

Add/Change #1039 (FastFrames statistics are not incremented correctly)